Drop Python 3.9 from CI, tox, and pyproject targets#252
Merged
Conversation
|
Findings (ordered by severity)
Security concerns: none found. Missing tests / edge cases: none beyond the tox usability regression above. |
Member
Author
|
@codex Change tox.ini to keep the |
Summary
Testing
|
|
Findings
Missing Tests / Edge Cases
Notes
If you want, I can propose a small patch to restore the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
3.10–3.13by editing.github/workflows/ci.ymland.github/workflows/publish.yml.tox.inienvlist from the genericpyto explicit environmentspy310,py311,py312,py313,style,sqlean.pyproject.tomlfrom>=3.9to>=3.10and updatetool.ty.environment.python-versionfrom3.9to3.10.CHANGELOG.mdentry noting the removal of Python 3.9 from test matrices and tooling targets.Testing
uv run --extra dev tox -l, which succeeded and reportedpy310,py311,py312,py313,style, andsqlean.tox -ldirectly failed initially becausetoxwas not installed in the global environment (expected in this workspace), and the workspace-localuvinvocation was used to validate the envlist instead.3.9and confirmed the changes (no remaining3.9matches in the updated files).Codex Task